index: Fix URL parameter parsing #89
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using DashCast or any other external site that may use the embedded URL, we want to make sure we are using the original location of the page instead of looking at the referrer URL. The referrer URL will not have the `url` or `entity` parameters. Fixes: AlexxIT#88
|
Rebased and confirmed that this is still needed on the v2.1.1 version. |
AlexxIT
force-pushed
the
master
branch
3 times, most recently
from
f29d0e1 to
6a7e35c
Compare
|
Not relevant in version 3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using DashCast or any other external site that may use the embedded
URL, we want to make sure we are using the original location of the page
instead of looking at the referrer URL. The referrer URL will not have
the
urlorentityparameters.Fixes: #88