-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for multiple streams #525
Conversation
One detail worth considering is that the stream name button/label shows the next stream instead of the current one. This is because I interprete it as a "button to switch to that stream" It may be best to show the active stream instead |
Yes. I think it's better to show current stream name. But tooltip can show next name. |
Alright, it now shows the name of the current stream |
This is a great feature but is this always going to load the first stream in the list or retain current one after a refresh. Really I want to load a low res each time but have the option to switch to HD periodically. Another thought would be possibly to have the option for 2 of these buttons or some option that could say select which camera you want and then whether you want it's main or substream, possibly even another again for mode although this may look crowded on the player. |
@direx1 It looks like the order you put the streams is the order they will load, and the highest quality mode that works will be the one that is shown for that steam. |
It loads the first url in the list. f you state a mode (mse, webrtc) it will use it, otherwise it will behave as usual and use the best available. |
This is awesome! I was just wishing this was a feature the other day😀 |
I've been using this for 2 weeks and it works very well, anything else you wish this PR to have @AlexxIT, or are you just too busy at the moment? :) |
I'm on vacation. Travelling. |
Thanks! |
@dbuezas when switching resolutions is there a way to keep the current "image" on the display, and then switch over right away to the new resolution? example, current behavior: display SD, switch to HD, black screen while loading, display HD anyway to avoid the black screen (or poster if configured) while switching resolutions? |
It would require quite a bit of a refactoring since the current implementation pretty much restarts all the video logic when the stream is swapped. Keeping the old stream alive until the new one starts means having two streams in parallel, and the code isn't architected to do that. I wonder what @AlexxIT thoughts on this are |
One cheap fake alternative is to take a screenshot of the old stream and show that while the new one loads |
Yes. Easiest solution will be to use screenshot as poster |
Would this PR also allow to select multiple entities, like:
|
Yes. PR works for entities |
Awesome, I should have tried before asking. Definitely works! |
Adds support for multiple streams per card, each with a different URL, name and mode (optional)
Closes #523