BREAKING CHANGE in HA 2021.12

[bafplus]

Although HA is giving suggestions for months WebRTC is still not updated to stay working with Home Assistant. From HA 2021.12 this will be a BREAKING CHANGE:

Error during setup of component webrtc
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/setup.py", line 229, in _async_setup_component
result = await task
File "/config/custom_components/webrtc/init.py", line 75, in async_setup
utils.register_static_path(hass.http.app, url_path, path)
File "/config/custom_components/webrtc/utils.py", line 74, in register_static_path
app'allow_cors'
File "/usr/local/lib/python3.9/site-packages/aiohttp/web_app.py", line 186, in getitem
return self._state[key]
KeyError: 'allow_cors'

[zvldz]

update to master

[bafplus]

I use the HACS version, shouldnt that be on master already? Op ma 6 dec. 2021 om 17:15 schreef zvldz ***@***.***>:

…

update to master — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#179 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABRCRWWJOZHMOHE6LSI7KB3UPTOSZANCNFSM5JPAMHZA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[zvldz]

Changes in the master version of the component, no release yet. You can install the master version via hacs

[bafplus]

You cant, HACS says:

Repository 'alexxit/webrtc' exists in the store.

[sean-m-sullivan]

Took me a moment in hacs when adding repository

[sean-m-sullivan]

however I just switched to master and have the same issue with allow_cors

[AlexxIT]

Duplicate

[bafplus]

Switching to Master did fix it, but i would suggest to push a new version else everyones HA install will fail on WebRTC next saturday.

[AlexxIT]

@bafplus if you see this error, you have not installed the master version

[bafplus]

@bafplus if you see this error, you have not installed the master version

As said above, master did fix it. Yet i highly suggest to push a version update to avoid mass failures by users on next HA update next saturday :-)

[gryphon-wg]

2AlexxIT
Installed master version, 2 time reboot, but still no luck

HACS: " version downloaded 0e45d1"
LOGS: Error during setup of component webrtc
Traceback (most recent call last):
File "/usr/src/homeassistant/homeassistant/setup.py", line 229, in _async_setup_component
result = await task
File "/config/custom_components/webrtc/init.py", line 75, in async_setup
utils.register_static_path(hass.http.app, url_path, path)
File "/config/custom_components/webrtc/utils.py", line 74, in register_static_path
app'allow_cors'
File "/usr/local/lib/python3.9/site-packages/aiohttp/web_app.py", line 186, in getitem
return self._state[key]
KeyError: 'allow_cors'
Integrations: Not loaded

[AlexxIT]

@gryphon-wg as you can see, line 74 don't have this code. So you haven't installed the master version

WebRTC/custom_components/webrtc/utils.py

Line 74 in 0e4d5d1

if 'allow_all_cors' in app:

[AlexxIT]

#156