Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes spot_fleet_capacity an environment variable so we can have less… #775

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

kurtwheeler
Copy link
Contributor

… for dev/staging than prod.

Issue Number

N/A I've just been seeing a lot of compute power getting spun up in staging.

Purpose/Implementation Notes

Staging and dev environments were set to request as much compute power as prod needs. Obviously rather wasteful.

Since the env files are encrypted, this sets spot_fleet_capacity to:

  • 100 for prod -- 10TB
  • 20 for staging -- 2TB
  • 10 for dev -- 1 TB

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

Testing this in dev would take more time that would be worth it I think. This is a simple change that should be very low risk since I set up the env var in the same way spot_price is set up. Therefore I think we're best off just testing it in staging and iterating from there in the low chance scenario where it fails.

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@dongbohu dongbohu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@kurtwheeler kurtwheeler merged commit d55616d into dev Nov 5, 2018
kurtwheeler added a commit that referenced this pull request Jan 10, 2019
…resources

Makes spot_fleet_capacity an environment variable so we can have less…
@wvauclain wvauclain deleted the kurtwheeler/limit-staging-resources branch July 11, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants