Isolate affy image tests and make them not use DLC #771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of disk space and to speed things up via parallelization.
ghost
assigned 
dongbohu
approved these changes
Nov 1, 2018
| # Clean up stuff circle provides that we don't need. | ||
| - run: sudo bash .circleci/cleanup_instance.sh | ||
|
|
||
| # Setup Postgres in a Container |
There was a problem hiding this comment.
Any special reason why C is capitalized?
There was a problem hiding this comment.
I guess because the comment is like a title which is why postgres is also capitalized? I just copied this line from the other job's config.
kurtwheeler
added a commit
that referenced
this pull request
Jan 10, 2019
…mage-tests Isolate affy image tests and make them not use DLC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
N/A https://circleci.com/gh/AlexsLemonade/refinebio/9082 failed
Purpose/Implementation Notes
We hit a:
error in the above-mentioned build. This was something we had been seeing before turning Docker Layer Caching off because if the cache is warmed on the volume that gets used by CircleCI for docker, then there may not be enough space to fit all of our images. This manifests itself by us not having enough room to download the Affy image onto it.
The solution I've come up with is to just not use The docker layer caching feature for the Affy image. However whether to use that feature or not is job-specific setting so I had to break them into their own job. However this is actually pretty sweet because the job they were in before took the longest to run, even with docker layer caching speeding things up.
Types of changes
Functional tests
This is a CI change so the passing CI tests show it's working.
Checklist