Fix downloader tests by adding floor to MAX_DOWNLOADER_JOBS_PER_NODE #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Miserlou
approved these changes
Oct 31, 2018
kurtwheeler
pushed a commit
that referenced
this pull request
Jan 10, 2019
Fix downloader tests by adding floor to MAX_DOWNLOADER_JOBS_PER_NODE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
N/A, failing CI: https://circleci.com/gh/AlexsLemonade/refinebio/8975
Purpose/Implementation Notes
The CI box doesn't have enough RAM for our normal calculation of MAX_DOWNLOADER_JOBS_PER_NODE to work on it. Therefore made it so that value will never go below 5 so we still can run a few jobs at a time on dev and in tests.
Types of changes
Functional tests
This is all about CI.
Checklist