Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readds the configuration necessary for circleci to cache our docker i… #760

Merged
merged 1 commit into from
Oct 30, 2018

Conversation

kurtwheeler
Copy link
Contributor

…mages.

Issue Number

N/A but this is related to dev friendliness because it decreases the time it takes to run circleci tests.

Purpose/Implementation Notes

When we had docker caching layer on the tests ran faster because all the images except for affy were cached, so we're turning it back on. We can't use it for affy since circleci won't give docker any more disk space, but this way we only have to pull that one image and the rest of the images should be quick.

Types of changes

  • New feature (non-breaking change which adds functionality)

Functional tests

Tests are currently running, once they finish I will rerun them to make sure the test times drop.

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Copy link
Contributor

@Miserlou Miserlou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay

@kurtwheeler kurtwheeler merged commit 7896c91 into dev Oct 30, 2018
@kurtwheeler kurtwheeler deleted the kurtwheeler/reenable-docker-caching branch October 30, 2018 17:40
kurtwheeler added a commit that referenced this pull request Jan 10, 2019
…r-caching

Readds the configuration necessary for circleci to cache our docker i…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants