Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kurtwheeler/increase cran timeout #759

Merged
merged 2 commits into from
Oct 30, 2018
Merged

Conversation

kurtwheeler
Copy link
Contributor

Issue Number

N/A I saw some circle builds fail because of communication issues with CRAN.

Purpose/Implementation Notes

Bumps the timeout of CRAN to one minute, hopefully that's enough.

Also addresses a security vulnerability which Github alerted us about, see the screenshot.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)

Functional tests

CircleCI covers this.

Checklist

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Screenshots

image

Copy link
Contributor

@Miserlou Miserlou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This happened to me locally as well

@kurtwheeler kurtwheeler merged commit 0c1d487 into dev Oct 30, 2018
@kurtwheeler kurtwheeler deleted the kurtwheeler/increase-cran-timeout branch October 30, 2018 16:04
@ghost ghost removed the review label Oct 30, 2018
kurtwheeler added a commit that referenced this pull request Jan 10, 2019
…timeout

Kurtwheeler/increase cran timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants