Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle no downloader work gracefully. #747

Merged
merged 6 commits into from
Oct 26, 2018

Conversation

kurtwheeler
Copy link
Contributor

Issue Number

N/A Came up during staging test

Purpose/Implementation Notes

I saw a lot of downloader jobs failing but it turns out it was just because the files they were supposed to download had already been downloaded so they passed an empty list to create_processor_jobs which wasn't ready for it.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply.

  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

@Miserlou
Copy link
Contributor

I don't think these tests will run in CI unless given a tag that matches one in the config. The change itself looks good though.

@kurtwheeler
Copy link
Contributor Author

Oh snap good catch.

@ghost ghost added the in progress label Oct 23, 2018
@ghost ghost added the in progress label Oct 26, 2018
@kurtwheeler kurtwheeler merged commit 8eaf729 into dev Oct 26, 2018
@kurtwheeler kurtwheeler deleted the kurtwheeler/graceful-non-downloads branch October 26, 2018 19:27
kurtwheeler added a commit that referenced this pull request Jan 10, 2019
…ownloads

Handle no downloader work gracefully.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants