Adds OrderingFilter to Search API #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Will this allow sorting by the number of samples? |
|
It does now. |
kurtwheeler
suggested changes
Oct 15, 2018
api/data_refinery_api/views.py
Outdated
| filter_class = ExperimentFilter | ||
|
|
||
| # Ordering | ||
| ordering_fields = ('samples_count', 'id', 'created_at', 'accession_code',) |
There was a problem hiding this comment.
Could we use source_first_published instead of created_at since users probably don't care when we discovered the sample existed?
kurtwheeler
approved these changes
Oct 15, 2018
5 tasks
kurtwheeler
pushed a commit
that referenced
this pull request
Jan 10, 2019
Adds OrderingFilter to Search API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
AlexsLemonade/refinebio-frontend#372 (comment)
Purpose/Implementation Notes
Adds
filters.OrderingFiltertoFilterBackends.Methods
Uses
ordering_fields = '__all__'since we have no sensitive data here.Types of changes
Functional tests
New assertions added