-
Notifications
You must be signed in to change notification settings - Fork 83
Explore Variant_Classification's Impact on TMB: Part 1: Filter vs no Filter #739
Explore Variant_Classification's Impact on TMB: Part 1: Filter vs no Filter #739
Conversation
Before you get into a fine detail review, @jashapiro can you give this a "big picture" review and see if it fits what you pictured for part 1 of #729 and your comment that that issue is based on: #728 (review) |
…on' into cansavvy/var_class_investigation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I would add something about the fractions of mutations that are coding vs. noncoding, especially in the context of comparisons among tumor types. If there were not a strong correlation between coding and (coding + noncoding) as you have shown, I would be very surprised, but if the proportions of coding and noncoding changes were different across different tumor types I would be somewhat less shocked (but still surprised).
Adding some plots of the proportion coding (filter/nofilter) in each sample, split by morphology, might be a useful addition. This is perhaps simpler to plot than the slopes.
"no_filter", | ||
"pbta-snv-mutation-tmb-coding.tsv" | ||
)) %>% | ||
# This variable is weird when binding but we don't need it for the plot so we'll just remove it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tell me more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm... It was weird when I used this kind of import and bind data.frames in another notebook but now its fine, so I deleted this step.
I'm all for doing this comparison, but it will require different datasets and different set up than what I have going on in this notebook. So can I propose that if what is here is okay then I can start a new notebook/ new PR that looks into non-coding/coding proportions? |
My language is imprecise here, I don't really mean coding/noncoding. I just mean a violin plot (or similar) of |
Whew, okay that is much easier. Will do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. Nothing too surprising!
Purpose/implementation Section
What scientific question is your analysis addressing?
Part 1 of #729
Short answer, not much different at all.
What was your approach?
short_histology
.What GitHub issue does your pull request address?
Part 1 of #729
Directions for reviewers. Tell potential reviewers what kind of feedback you are soliciting.
Variant_Classification
breakdown #729? "How does the nonsynonymous filter affect TMB"?Is the analysis in a mature enough form that the resulting figure(s) and/or table(s) are ready for review?
Yes. Here's the rendered notebook:
explore_nonsynfilter.nb.html.zip
Results
What types of results are included (e.g., table, figure)?
Plots can be seen here explore_nonsynfilter.nb.html.zip
What is your summary of the results?
Overall TMB comparisons do not seem to be affected much by filter of nonsynonymous mutations.
Reproducibility Checklist
Documentation Checklist
I haven't added a README since this is a side analysis. The main information is in the Rmd. It's not a lone standing module so I also didn't add it to the table. But if we would like these items to be added, I can.
README
and it is up to date.analyses/README.md
and the entry is up to date.