-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"View > Toggle word-wrap" is the same for all tabs instead if showing status for current tab #5492
Comments
Apparently, this issue affects every item under View menu, not just "Toggle word-wrap". Tested with both Qt5 and Gtk Cuda versions. By the way, I suggest to rename items removing "Toggle" from them. "Word-wrap", "Line numbers" and so on. |
What is missed here: setting flag FNeedUpdateMenuChecks when different tab gets focus. easy to fix. |
but I like it more as now. it is more structured. |
Note: updating of checkmarks is run on timer 'idle event'. not immedeately. |
Thanks. Not being immediately is not ideal, we can see the checkmark changing to checked/unchecked a moment after opening the menu, but it's OK, the important is now it's working. By the way, maybe is this idle event the way to fix what I asked here? To disable "Rename" item in File menu when file is untitled (never saved). |
Yes, good small idea, did it now. |
Thanks. Could this idle event trick fix the old issue #4893? It would actually be a workaround, just to minimize the issue. |
Tested with clean Cuda release.
Results:
Now, "View > Toggle word-wrap" is checked for all tabs, but word-wrap is only enabled in a single tab.
The first item of "View" menu is a captions saying "--- Current tab properties ---", so items such as "Toggle word-wrap" should reflect current tab word-wrap state.
The text was updated successfully, but these errors were encountered: