Refactor layer surface implementations (again) #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alebastr
force-pushed
the
layer-surfaces-v3
branch
2 times, most recently
from
d1ad77c to
c980692
Compare
|
Okay, I haven't found any new issues with both implementations. Guess it's ready for review and wider testing... This PR also supersedes #545 |
|
Awesome stuff @alebastr! |
Previous attempts to use auto exclusive zone from gtk-layer-shell failed because gls was expecting real booleans (`TRUE`/`FALSE`) as set_anchor arguments. With that being fixed, gtk_layer_auto_exclusive_zone_enable makes gls handle everything related to the bar resizing. The only remaining purpose of onConfigureGLS is to log warnings and bar size changes; gtk-layer-shell code path no longer needs saved width_ or height_ values.
Extract two surface implementations from the bar class: GLSSurfaceImpl and RawSurfaceImpl. This change allowed to remove _all_ surface type conditionals and significantly simplify the Bar code. The change also applies PImpl pattern to the Bar, allowing to remove some headers and fields from `bar.hpp`.
Replace a couple of header includes with forward declarations.
wayland log shows that some changes were committed twice and some weren't committed until the next redraw.
Invisible bar on a `top` layer would still intercept pointer events and stop them from reaching windows below. Always changing the layer to to `bottom` along with making bar invisible would prevent that.
alebastr
force-pushed
the
layer-surfaces-v3
branch
from
c980692 to
9c56656
Compare
Sorry, that wasn't conscious. Been working with different code style too much 😄 |
|
Tested and LGTM, thanks for this refacto so far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to update the bar code for #860 that went overboard. I'm pretty sure that something is broken in this branch, just haven't figured out what. I'll be keeping this as a draft until I'm convinced that the only collateral damage is logs.
GLSSurfaceImplworks fine for me so far, which is not surprising with how small it is after lettinggtk-layer-shellmanage exclusive zone.RawSurfaceImplis not so extensively tested, but I'm going to switch to it for next few days and try all the configuration changes possible via IPC.The end goal is a live configuration reload and updates from sway IPC events, but the path is long (alebastr/Waybar@master...swaybar-ipc is a somewhat ugly proof of concept for the IPC part).
It might also require some feedback and breaking changes as I don't know how close we want to be to swaybar behavior and how good is the idea to apply all supported configuration from sway's
barconfig_updateevent.