Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mpd module hang/crash after suspend #3793

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
make debug less annoying
  • Loading branch information
bretello committed Nov 27, 2024
commit e4a497989bea49dc81e8854415c58311e336eed5
2 changes: 1 addition & 1 deletion include/util/command.hpp
Original file line number Diff line number Diff line change
@@ -50,7 +50,7 @@ inline int close(FILE* fp, pid_t pid) {
ret = waitpid(pid, &stat, WCONTINUED | WUNTRACED);

if (WIFEXITED(stat)) {
spdlog::debug("Cmd exited with code {}", WEXITSTATUS(stat));
spdlog::trace("Cmd exited with code {}", WEXITSTATUS(stat));
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I changed this (and below) to trace since they made debugging with -l debug very noisy. I'll be happy to revert this and/or open another PR in case we want separation of concerns.

} else if (WIFSIGNALED(stat)) {
spdlog::debug("Cmd killed by {}", WTERMSIG(stat));
} else if (WIFSTOPPED(stat)) {
2 changes: 1 addition & 1 deletion src/main.cpp
Original file line number Diff line number Diff line change
@@ -28,7 +28,7 @@ void* signalThread(void* args) {

switch (signum) {
case SIGCHLD:
spdlog::debug("Received SIGCHLD in signalThread");
spdlog::trace("Received SIGCHLD in signalThread");
if (!reap.empty()) {
reap_mtx.lock();
for (auto it = reap.begin(); it != reap.end(); ++it) {