fix(custom): stop mixing manual and automatic arg indexing #3617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current documentation for the custom module suggests mixing manual
(`{icon}`) and automatic (`{}`) indexing of format args. Newer versions
of the fmt library seem to not support this anymore (see issue Alexays#3605).
This commit introduces a name for the `text` output of the script, so
that `{text}` can now be used instead of `{}` in the configuration.
|
Please, update the man (FORMAT REPLACEMENTS in waybar-custom.5.scd) and the example config. |
|
To help users, can you add a warning if the user's format contains "{}"? |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation for the custom module suggests mixing manual (
{icon}) and automatic ({}) indexing of format args. Newer versions of the fmt library seem to not support this anymore (see issue #3605).This commit introduces a name for the
textoutput of the script, so that{text}can now be used instead of{}in the configuration. The documentation in the wiki should be updated upon rolling out this change.An alternative way would be to just replace
{}with{0}in the documentation, then this pull request wouldn’t be required.