-
-
Notifications
You must be signed in to change notification settings - Fork 736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AModule: Cursor config option #3398
Conversation
To avoid yet another breaking change, I prefer to keep the cursor change logic but make it deactivatable in the settings. WDYT? |
Yeah, i actually agree. I was just waiting for some feedback before I changed it from the original change. I can tweak the change when I get home. |
@Alexays Alright, implemented fallback to default behavior when someone doesn't provide a configuration. |
also, statically configure the cursor type
@Alexays Sorry, fixed. Also noticed the mouse enter and leave were a breaking change with tool-tips so moved it back there for the default behavior when not configured. |
@Alexays Whenever you get a chance |
Thanks! |
👏 |
I was surprised when my waybar crashed coming back from vacation. Turns out it was my own fault in the best kind of way. Had a testing configuration related to these changes left over in my config file from this:
As I wrote in the man page, attempting to use unavailable cursor options WILL crash your app! 😂 |
Seen a lot of discussion activity around this again... resurrecting the PR #3274 that resolves #3239. Follow up to work done in #3108 to make this opt in instead of always forced on users.
One thing that might be nice is to set a global option for this... but I didn't see a way of doing that easily, atm.