Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hyprlands window-rewrite #2809

Closed
wants to merge 1 commit into from

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Jan 5, 2024

Resolves: #2718 found during testing another feature in pipeline. The window rewrites work on boot for me and no issues dragging between monitors anymore.

cc @Syndelis

@khaneliman khaneliman force-pushed the window-rewrite-fix branch 2 times, most recently from 14fa41c to 46d58e9 Compare January 6, 2024 01:21
@Syndelis
Copy link
Contributor

Syndelis commented Jan 6, 2024

Although this would solve the issue, I feel like getting the clients information and reprocessing the icon for every update seems overkill. The problem seems to appear when a window is dragged to a workspace that doens't exist in tha same bar it originated from. A less performance-intensive solution would be to check if the icon is empty when the window is moved to another workspace here. I'll see what I can hack together tomorrow and will get back here.

@khaneliman
Copy link
Contributor Author

Oh yeah, it's definitely not the most elegant... I was just excited to finally see the bar function the way I had hoped finally..

@Syndelis
Copy link
Contributor

Syndelis commented Jan 8, 2024

Sorry for being late, @khaneliman ! I've opened #2817 which should hopefully fix this problem as well. Could you verify that works for your setup?

@khaneliman
Copy link
Contributor Author

closing with work being done in #2817

@khaneliman khaneliman closed this Jan 9, 2024
@khaneliman khaneliman deleted the window-rewrite-fix branch January 9, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

window-rewrite missing firefox icon upon boot (hyprland/workspaces module)
3 participants