Skip to content

Commit

Permalink
hyprland/backend: drop unnecessary getaddrinfo call
Browse files Browse the repository at this point in the history
Hyprland hasn't been using TCP sockets for IPC since the first release,
so this getaddrinfo call and its result was never needed.

Additionally, it leaks the `aiRes`, causing test failure under ASan.
  • Loading branch information
alebastr committed Aug 18, 2024
1 parent 21906f0 commit 1f23b30
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions src/modules/hyprland/backend.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -148,22 +148,12 @@ void IPC::unregisterForIPC(EventHandler* ev_handler) {
std::string IPC::getSocket1Reply(const std::string& rq) {
// basically hyprctl

struct addrinfo aiHints;
struct addrinfo* aiRes = nullptr;
const auto serverSocket = socket(AF_UNIX, SOCK_STREAM, 0);

if (serverSocket < 0) {
throw std::runtime_error("Hyprland IPC: Couldn't open a socket (1)");
}

memset(&aiHints, 0, sizeof(struct addrinfo));
aiHints.ai_family = AF_UNSPEC;
aiHints.ai_socktype = SOCK_STREAM;

if (getaddrinfo("localhost", nullptr, &aiHints, &aiRes) != 0) {
throw std::runtime_error("Hyprland IPC: Couldn't get host (2)");
}

// get the instance signature
auto* instanceSig = getenv("HYPRLAND_INSTANCE_SIGNATURE");

Expand Down

0 comments on commit 1f23b30

Please sign in to comment.