Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add get mime type safelly and make google drive deps trully optional #85

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

AlexandreSenpai
Copy link
Owner

No description provided.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 52.08333% with 23 lines in your changes missing coverage. Please review.

Project coverage is 78.01%. Comparing base (35815d6) to head (c31fa6c).

Files with missing lines Patch % Lines
enma/infra/adapters/storage/google_drive.py 0.00% 11 Missing ⚠️
enma/infra/adapters/repositories/mangadex.py 11.11% 8 Missing ⚠️
enma/domain/utils/mime.py 66.66% 3 Missing ⚠️
enma/infra/adapters/repositories/nhentai.py 93.75% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
- Coverage   78.90%   78.01%   -0.90%     
==========================================
  Files          24       25       +1     
  Lines        1266     1301      +35     
==========================================
+ Hits          999     1015      +16     
- Misses        267      286      +19     
Flag Coverage Δ
pytest 78.01% <52.08%> (-0.90%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlexandreSenpai AlexandreSenpai merged commit 24b31cf into master Nov 13, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant