Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ToNameValueCollection() throws when a column is provided but a search is not. #31

Closed
VictorioBerra opened this issue Oct 30, 2018 · 2 comments
Closed

ToNameValueCollection() throws when a column is provided but a search is not. #31

VictorioBerra opened this issue Oct 30, 2018 · 2 comments

Comments

@VictorioBerra
Copy link
Contributor

If you use the DataTablesAjaxPostModel the ToNameValueCollection forces you to provide a search object, even if you just want to order and not search.
@VictorioBerra
Copy link
Contributor Author

The fix should be to add some null checks.

model[$"columns[{i}][search][value]"] = Columns[i].Search?.Value;
model[$"columns[{i}][search][regex]"] = Columns[i].Search?.Regex.ToString();

VictorioBerra added a commit to VictorioBerra/DataTables.Queryable that referenced this issue Oct 31, 2018
@VictorioBerra
Add null checks around Columns[i].Search
d713c26 
Ref AlexanderKrutov#31
@VictorioBerra VictorioBerra mentioned this issue Oct 31, 2018
Merged
@AlexanderKrutov
Copy link
Owner

Thank you! The fix is included in 1.7.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@VictorioBerra @AlexanderKrutov