Fix collision check positions

AlexProgrammerDE · Dec 2, 2024 · d611977 · d611977
1 parent f738e8c
commit d611977
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/server/src/main/java/com/soulfiremc/server/pathfinding/graph/CollisionCalculator.java b/server/src/main/java/com/soulfiremc/server/pathfinding/graph/CollisionCalculator.java
@@ -39,8 +39,8 @@ public class CollisionCalculator {
         var bodyPartArray = new boolean[BodyPart.VALUES.length];
         for (var bodyPart : BodyPart.VALUES) {
           bodyPartArray[bodyPart.ordinal()] = blockState.collidesWith(
-            bodyPart.offset(SFVec3i.from(0, 1, 0)).toVector3i(),
-            Player.STANDING_DIMENSIONS.makeBoundingBox(diagonal.offsetSide(SFVec3i.ZERO).toVector3d())
+            bodyPart.offset(diagonal.offset(SFVec3i.ZERO)).toVector3i(),
+            Player.STANDING_DIMENSIONS.makeBoundingBox(diagonal.edgeOffset(SFVec3i.ZERO).toVector3d())
           );
         }
         diagonalsArray[diagonal.diagonalArrayIndex()] = bodyPartArray;

diff --git a/...main/java/com/soulfiremc/server/pathfinding/graph/actions/movement/MovementDirection.java b/...main/java/com/soulfiremc/server/pathfinding/graph/actions/movement/MovementDirection.java
@@ -94,7 +94,7 @@ public SFVec3i offset(SFVec3i vector) {
     };
   }
 
-  public SFVec3i offsetSide(SFVec3i vector) {
+  public SFVec3i edgeOffset(SFVec3i vector) {
     return switch (this) {
       case NORTH_EAST -> vector.add(1, 0, 0);
       case NORTH_WEST -> vector.add(0, 0, 0);