Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update mongo-objectid + exposed it #16

Merged
merged 5 commits into from
May 15, 2020
Merged

Conversation

Alex-Werner
Copy link
Owner

@Alex-Werner Alex-Werner commented May 15, 2020

Issue being fixed or implemented

In order to allow users to access ObjectID without the need to install the ObjectID package by themselves, we need to expose it.

What was done

  • updated mongo-objectid to 1.2.0 (adds getTimestamp and getDate()) method.
  • exposed ObjectID.
  • updated dependencies (fix security issue : GHSA-vh95-rmgr-6w4m)

How Has This Been Tested?

Added simple test for proper exposition

Notes

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@Alex-Werner Alex-Werner merged commit dd9b6b4 into develop May 15, 2020
@Alex-Werner Alex-Werner mentioned this pull request May 15, 2020
@Alex-Werner Alex-Werner deleted the chore/update-deps branch May 15, 2020 05:57
Alex-Werner added a commit that referenced this pull request Aug 29, 2020
* chore: update mongo-objectid + exposed it (#16)

* chore: updated mongo-objectid to 1.2.0

* feat: exposed ObjectID

* test: added exposition test

* chore: updated mongo-objectid to 1.2.1

* chore: bump dependencies to latest

fix security issue.

* fix: consistency issue with getDocument on unfound doc (#15)

Match fs adapter comportment

* chore(package): bump to 3.0.0

* fix: issue with lower fill factor than order for single element tree (#14)

* fix: issue with lower fill factor than order for single element tree (#13)

* fix(SBFRoot/findLowerThan): finding document on equal case for lte

Specific case when order is bigger than actual size

* style: formatting

* test: add tests for tree with lower size than order

Co-authored-by: Anurag Vohra <[email protected]>

* docs: docsify

Co-authored-by: Anurag Vohra <[email protected]>
Alex-Werner added a commit that referenced this pull request Aug 29, 2020
* chore: update mongo-objectid + exposed it (#16)

* chore: updated mongo-objectid to 1.2.0

* feat: exposed ObjectID

* test: added exposition test

* chore: updated mongo-objectid to 1.2.1

* chore: bump dependencies to latest

fix security issue.

* fix: consistency issue with getDocument on unfound doc (#15)

Match fs adapter comportment

* chore(package): bump to 3.0.0

* fix: issue with lower fill factor than order for single element tree (#14)

* fix: issue with lower fill factor than order for single element tree (#13)

* fix(SBFRoot/findLowerThan): finding document on equal case for lte

Specific case when order is bigger than actual size

* style: formatting

* test: add tests for tree with lower size than order

Co-authored-by: Anurag Vohra <[email protected]>

* feat: add isReady method + remove waitFor deps (#18)

* feat(SBTree): add isReady method

* feat: moved waitFor to use isReady method

* fix: fslock breaking change

* docs: docsify documentation (#22)

* chore: update mongo-objectid + exposed it (#16)

* chore: updated mongo-objectid to 1.2.0

* feat: exposed ObjectID

* test: added exposition test

* chore: updated mongo-objectid to 1.2.1

* chore: bump dependencies to latest

fix security issue.

* fix: consistency issue with getDocument on unfound doc (#15)

Match fs adapter comportment

* chore(package): bump to 3.0.0

* fix: issue with lower fill factor than order for single element tree (#14)

* fix: issue with lower fill factor than order for single element tree (#13)

* fix(SBFRoot/findLowerThan): finding document on equal case for lte

Specific case when order is bigger than actual size

* style: formatting

* test: add tests for tree with lower size than order

Co-authored-by: Anurag Vohra <[email protected]>

* docs: docsify

Co-authored-by: Anurag Vohra <[email protected]>

* tests!: reorganize tests + nested functional

BREAKING: get document unfound returns null instead of {}

* chore: added DS and nyc output to ignored entities

* chore!: return single document as [] + split lodash module

* chore: update dev deps

* style: eslint fix

* fix:  handling on unfound field

* feat!: remove single object as array

* chore: add badges

Co-authored-by: Anurag Vohra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant