Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing star selector to tests. #69

Closed
wants to merge 1 commit into from

Conversation

aldhsu
Copy link

@aldhsu aldhsu commented Sep 24, 2018

Hi @AleshaOleg, I was trying to use stylelint and found this problem with the * selector. I might attempt to fix it later but I might not get to it.

@aldhsu
Copy link
Author

aldhsu commented Sep 24, 2018

Nevermind. I think I will need to do some more investigation into the source of the error.

@aldhsu aldhsu closed this Sep 24, 2018
@aldhsu aldhsu deleted the star-selector branch September 24, 2018 02:51
@AleshaOleg
Copy link
Owner

AleshaOleg commented Sep 24, 2018

@aldhsu hey! Can I help you? Please send me an example of how you're using stylelint, and I will try to reproduce

@AleshaOleg
Copy link
Owner

Actually, you're right. postcss-sass now don't have any tests for *. I'll do it.

@AleshaOleg
Copy link
Owner

Just added test - 88d6e46

Seems it's working fine🤔

@aldhsu
Copy link
Author

aldhsu commented Sep 24, 2018

@AleshaOleg thanks for the quick reply. I jumped to conclusions. Had nothing to do with post-css was the parser gonzales-pe.
Was something like this:

*, 
*:before, 
*:after,
   box-sizing: inherit

Which sounds like this issue tonyganch/gonzales-pe#238.
The error was happening at the *, but the problem is actually at *:after,.

@AleshaOleg
Copy link
Owner

@aldhsu ok, sorry. Nothing I can do there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants