fixes #113 using fetch + keepalive #133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#113 * instead of jQuery, we check if the browser supports `fetch` and use it with `keepalive: true` * otherwise, fallback to plain JS
|
@joker-777 can you take a look? :) |
joker-777
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
@gingerlime Sorry, I had a look at it already yesterday but then forgot to write a comment. The code changes look very good. How can I test it best?
|
@joker-777 thank you. We have some tests, but they are far from perfect. I tested manually with an HTML page that loaded a simple experiment, and I saw that it was using |
|
@gingerlime Sounds good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetchand use it with
keepalive: true