Coerce passed type to TS before invoking ::name() #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we're running the macro on a type which has an in-scope trait containing a `::name` member, the compiler will not know which to invoke. This clarifies that in the macro's context, we want to invoke the TS::name trait method by first casting the argument to the TS trait. This pattern is in some other parts of the macro, I think this one was just triggered previously. Signed-off-by: Paul R. Tagliamonte <[email protected]>
|
Thanks, appreciate it! |
|
@NyxCode Thank you! What a fast review and merge; and thank you very much for further fixing the general case! I really appreciate your work deeply! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we're running the macro on a type which has an in-scope trait containing a
::namemember, the compiler will not know which to invoke.This clarifies that in the macro's context, we want to invoke the TS::name trait method by first casting the argument to the TS trait.
This pattern is in some other parts of the macro, I think this one wasn't triggered previously.
Goal
What is this PR attempting to achieve? Is it a bug fix? Is it related to an issue?
Closes #
Changes
How did you go about solving the problem?
Checklist