Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MSRV to cargo.toml and README #300

Merged
merged 1 commit into from
Apr 8, 2024
Merged

Add MSRV to cargo.toml and README #300

merged 1 commit into from
Apr 8, 2024

Conversation

escritorio-gustavo
Copy link
Contributor

Goal

Help users know if their Rust version is supported.
Related #285

Changes

  • Added MSRV to ts-rs/Cargo.toml
  • Added MSRV to README
  • Removed the "todo" section from the README, as all of those todos were already done

Checklist

  • I have followed the steps listed in the Contributing guide.
  • If necessary, I have added documentation related to the changes made.
  • I have added or updated the tests related to the changes made.

Copy link
Collaborator

@NyxCode NyxCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (already merged anyway :D)

@escritorio-gustavo
Copy link
Contributor Author

Sorry about that, I requested the review and then I was like "this... really doesn't need a review, it's just 1 line in Cargo.toml and some text on the README" lol

@NyxCode
Copy link
Collaborator

NyxCode commented Apr 8, 2024

np!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants