Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for #[serde(untagged)] on enum variants #226

Merged
merged 7 commits into from
Feb 8, 2024

Conversation

escritorio-gustavo
Copy link
Contributor

As of serde-rs/serde#2403 serde supports adding #[serde(untagged)] to individual enum variants, this PR adds support for it to ts-rs

@escritorio-gustavo escritorio-gustavo changed the title Add support for #[serde(untagged)] on enum variants Add support for #[serde(untagged)] on enum variants Feb 5, 2024
Copy link
Collaborator

@NyxCode NyxCode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks!
I think enum.rs:136 is not formatted correctly.

Other than that, nice & elegant change!

@escritorio-gustavo escritorio-gustavo merged commit be74ebb into main Feb 8, 2024
4 checks passed
@escritorio-gustavo escritorio-gustavo deleted the support_untagged_variant branch February 8, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants