-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add "as" derive helper attribute #174
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry about the mess, the previous comments were not marking the specific lines I was referring to, but the whole set of changes
I have fixed the merge conflict, but I haven't passed the fix through the compiler, needs to be checked |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have applied the changes I previously requested. @NyxCode, this PR is a pretty significative change. What do you think?
I love it! Thanks @josema03, and thank you so much @escritorio-gustavo for putting in the time to clean this up! |
From my side, this is ready to merge! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
This implements the feature requested in the following issue: #113
Please take a look at it and let me know if I need to make any other change to have it merged.