[7.4-stable] Prevent redefining 'alchemy-menubar' custom element when using Turbo #3167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit uses `data-turbo-eval="false"` to prevent defefining 'alchemy-menubar' custom element when navigating between pages with Turbo. Without this, we are getting the following error after each `Turbo.visit`: ``` Uncaught DOMException: CustomElementRegistry.define: 'alchemy-menubar' has already been defined as a custom element ``` (cherry picked from commit 1f31c91)
alchemycms-bot
force-pushed
the
backport/7.4-stable/pr-3095
branch
from
26c5dbd to
d06cb2a
Compare
3 tasks
tvdeyen
approved these changes
Jan 24, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 7.4-stable #3167 +/- ##
===========================================
Coverage 96.48% 96.48%
===========================================
Files 237 237
Lines 6421 6421
===========================================
Hits 6195 6195
Misses 226 226 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto7.4-stable:Questions ?
Please refer to the Backport tool documentation