fix attribute sorting across Ruby versions #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
added
backport-to-7.1-stable
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3153 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 236 236
Lines 6360 6360
=======================================
Hits 6143 6143
Misses 217 217 ☔ View full report in Codecov by Sentry. |
|
@robinboening a rebase should fix Rails 7.0 tests. Can you squash the "fix specs" commit into the previous one, while you're at it? |
absolutely! |
robinboening
force-pushed
the
fix_sorted_attributes
branch
from
0c60342 to
a51b2d1
Compare
Chaining sort_by methods caused issues because each subsequent sort_by effectively overrides the previous sort order by re-sorting the entire array based solely on the new condition. This can disrupt the prioritization of earlier sorting criteria. Interestingly, chaining multiple sort_by calls has been working as expected in Ruby versions prior to 3.3.1, as the underlying behavior of Array#sort_by appears to have been consistent in preserving the prioritization of earlier steps. Switching to a single sort_by call ensures the logic remains robust and compatible across Ruby versions, including 3.3.1. Fixes AlchemyCMS#3152
robinboening
force-pushed
the
fix_sorted_attributes
branch
from
a51b2d1 to
fe62c1f
Compare
This was referenced Jan 24, 2025
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chaining sort_by methods caused issues because each subsequent sort_by effectively overrides the previous sort order by re-sorting the entire array based solely on the new condition. This can disrupt the prioritization of earlier sorting criteria.
Interestingly, chaining multiple sort_by calls has been working as expected in Ruby versions prior to 3.3.1, as the underlying behavior of Array#sort_by appears to have been consistent in preserving the prioritization of earlier steps.
Switching to a single sort_by call ensures compatibility across Ruby versions, including 3.3.1 and beyond.
Fixes #3152