Resizable elements window #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tinymce has a new css class prefix, that broke the fullscreen mode.
Allows to drag the divider between the preview and elements windows in order to resize the elements window. This is very helpful, if the elements window is too narrow when lots of nested elements exist.
Makes sure the elements window width is the same across pages. Uses a cookie, so we can read the value from Rails and put it on the body tag, so it is immediatly available on page render. Otherwise we would see the element window resizing on every page visit. SSR ftw \o/
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3097 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 236 236
Lines 6334 6334
=======================================
Hits 6118 6118
Misses 216 216 ☔ View full report in Codecov by Sentry. |
sascha-karnatz
approved these changes
Dec 2, 2024
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Allows to drag the divider between the preview and elements windows in order to resize the elements window.
This is very helpful, if the elements window is too narrow when lots of nested elements exist.
It makes sure the elements window width is the same across pages. Uses a cookie, so we can read the value from Rails and put it on the body tag, so it is immediately available on page render. Otherwise we would see the element window resizing on every page visit.
SSR ftw \o/
refs #2733
Screencast
https://www.loom.com/share/87151d6797c04b2aa10900e384e54cf7
Checklist