Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Ingredient::Picture): Do not try to localize CSS class if empty #3031

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Sep 6, 2024

An empty css class leads to a ArgumentError in I18n.

Fix for feature introduced in #2917

An empty css class leads to a ArgumentError in I18n.
@tvdeyen tvdeyen requested a review from a team as a code owner September 6, 2024 14:54
@tvdeyen tvdeyen added this to the 7.3 milestone Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (dbed496) to head (881014f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3031   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         237      237           
  Lines        6404     6404           
=======================================
  Hits         6178     6178           
  Misses        226      226           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tvdeyen tvdeyen merged commit 525baf6 into AlchemyCMS:main Sep 8, 2024
39 checks passed
@tvdeyen tvdeyen deleted the fix-picture-ingredient-update branch September 8, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants