Fallback to @page var if no Current.page is set #3011
Merged
+25
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With Alchemy 7.2 (AlchemyCMS#2701) we started to use `Alchemy::Current.page` for rendering elements of current page. If one has a custom controller to render Alchemy content with: render(template: "alchemy/pages/show") it is now empty if `Alchemy::Current.page` is not set. Someday we might deprecate the `@page` instance variable, but until then we need to fall back to it.
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3011 +/- ##
=======================================
Coverage 96.47% 96.47%
=======================================
Files 237 237
Lines 6403 6403
=======================================
Hits 6177 6177
Misses 226 226 ☔ View full report in Codecov by Sentry. |
sascha-karnatz
approved these changes
Sep 3, 2024
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
With Alchemy 7.2 (#2701) we started to use
Alchemy::Current.pagefor rendering elements of current page. If one has a custom controller to render Alchemy content with:it is now empty if
Alchemy::Current.pageis not set.Someday we might deprecate the
@pageinstance variable, but until then we need to fall back to it.Checklist