Fix combining search filters and pagination #2978
Merged
+16
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `search_filter_params` method in Alchemy's Resource Controller converts the permitted attributes to a Hash, stopping them from being recognized as something like a nested Hash in our per page select. This commit uses duck-typing in order to find out whether we're looking at a nested Hash. This should work with both ActionController::Parameters and with a Hash.
mamhoff
added a commit
to mamhoff/alchemy_cms
that referenced
this pull request
Jul 30, 2024
When using custom Ransack filters, this will allow combining them with the pagination. Without this, we can only combine the one ransack field we use for searching in the top bar. See AlchemyCMS#2978 for context.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2978 +/- ##
==========================================
+ Coverage 95.96% 96.02% +0.05%
==========================================
Files 232 233 +1
Lines 6273 6309 +36
==========================================
+ Hits 6020 6058 +38
+ Misses 253 251 -2 ☔ View full report in Codecov by Sentry. |
tvdeyen
approved these changes
Jul 30, 2024
tvdeyen
added
backport-to-7.0-stable
This was referenced Jul 30, 2024
💔 Some backports could not be created
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
mamhoff
added a commit
to mamhoff/alchemy_cms
that referenced
this pull request
Jul 30, 2024
When using custom Ransack filters, this will allow combining them with the pagination. Without this, we can only combine the one ransack field we use for searching in the top bar. See AlchemyCMS#2978 for context.
mamhoff
added a commit
to mamhoff/alchemy_cms
that referenced
this pull request
Aug 1, 2024
When using custom Ransack filters, this will allow combining them with the pagination. Without this, we can only combine the one ransack field we use for searching in the top bar. See AlchemyCMS#2978 for context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
search_filter_paramsmethod in Alchemy's Resource Controller converts the permitted attributes to a Hash, stopping them from being recognized as something like a nested Hash in our per page select. This commit uses duck-typing in order to find out whether we're looking at a nested Hash. This should work with both ActionController::Parameters and with a Hash.