Remove to_jq_upload

app/controllers/concerns/alchemy/admin/uploader_responses.rb

@@ -11,7 +11,7 @@ def successful_uploader_response(file:, status: :created)
           name: file.name)
 
         {
-          json: uploader_response(file: file, message: message),
+          json: {message: message},
           status: status
         }
       end
@@ -23,19 +23,10 @@ def failed_uploader_response(file:)
           name: file.name)
 
         {
-          json: uploader_response(file: file, message: message),
+          json: {message: message},
           status: :unprocessable_entity
         }
       end
-
-      private
-
-      def uploader_response(file:, message:)
-        {
-          files: [file.to_jq_upload],
-          message: message
-        }
-      end
     end
   end
 end

app/models/alchemy/attachment.rb

@@ -102,14 +102,6 @@ def allowed_filetypes
 
     # Instance methods
 
-    def to_jq_upload
-      {
-        "name" => read_attribute(:file_name),
-        "size" => read_attribute(:file_size),
-        "error" => errors[:file].join
-      }
-    end
-
     def url(options = {})
       if file
         self.class.url_class.new(self).call(options)

app/models/alchemy/picture.rb

@@ -224,16 +224,6 @@ def update_name_and_tag_list!(params)
       save!
     end
 
-    # Returns a Hash suitable for jquery fileupload json.
-    #
-    def to_jq_upload
-      {
-        name: image_file_name,
-        size: image_file_size,
-        error: errors[:image_file].join
-      }
-    end
-
     # Returns the picture description for a given language.
     def description_for(language)
       descriptions.find_by(language: language)&.text

lib/alchemy/test_support/shared_uploader_examples.rb

@@ -7,6 +7,5 @@
     expect(response.status).to eq(422)
     json = JSON.parse(response.body)
     expect(json).to have_key("message")
-    expect(json).to have_key("files")
   end
 end

spec/controllers/alchemy/admin/attachments_controller_spec.rb

@@ -88,7 +88,6 @@ module Alchemy
           expect(response.status).to eq(201)
           json = JSON.parse(response.body)
           expect(json).to have_key("message")
-          expect(json).to have_key("files")
         end
       end
 
@@ -135,7 +134,6 @@ module Alchemy
             expect(response.status).to eq(202)
             json = JSON.parse(response.body)
             expect(json).to have_key("message")
-            expect(json).to have_key("files")
           end
 
           it "replaces the file" do

spec/controllers/alchemy/admin/pictures_controller_spec.rb

@@ -134,7 +134,7 @@ module Alchemy
       subject { post :create, params: params }
 
       let(:params) { {picture: {name: ""}} }
-      let(:picture) { mock_model("Picture", humanized_name: "Cute kittens", to_jq_upload: {}) }
+      let(:picture) { mock_model("Picture", humanized_name: "Cute kittens") }
 
       context "with passing validations" do
         before do
@@ -150,7 +150,6 @@ module Alchemy
           expect(response.status).to eq(201)
           json = JSON.parse(response.body)
           expect(json).to have_key("message")
-          expect(json).to have_key("files")
         end
       end
 

spec/models/alchemy/picture_spec.rb

@@ -396,31 +396,6 @@ module Alchemy
       end
     end
 
-    describe "#to_jq_upload" do
-      subject { picture.to_jq_upload }
-
-      let(:picture) { build_stubbed(:alchemy_picture, image_file_name: "cute-kittens.jpg", image_file_size: 1024) }
-
-      it "returns a hash containing data for jquery fileuploader" do
-        is_expected.to be_an_instance_of(Hash)
-        is_expected.to include(name: picture.image_file_name)
-        is_expected.to include(size: picture.image_file_size)
-      end
-
-      context "with error" do
-        let(:picture) { build_stubbed(:alchemy_picture) }
-
-        before do
-          expect(picture).to receive(:errors).and_return({image_file: %w[stupid_cats]})
-        end
-
-        it "returns hash with error message" do
-          is_expected.to be_an_instance_of(Hash)
-          is_expected.to include(error: "stupid_cats")
-        end
-      end
-    end
-
     describe "#restricted?" do
       subject { picture.restricted? }