Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompile CSS files into Gem #2886

Merged
merged 16 commits into from
Jun 26, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ jobs:
with:
ruby-version: ${{ matrix.ruby }}
bundler-cache: true
rubygems: "latest"
- name: Restore apt cache
id: apt-cache
uses: actions/cache@v4
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
with:
ruby-version: "3.0"
bundler-cache: true
rubygems: "latest"
- name: Lint Ruby files
run: bundle exec standardrb
ESLint:
Expand Down
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@ pkg
tmp
log
.sass-cache
spec/dummy/app/assets/builds/*
!spec/dummy/app/assets/builds/.keep
spec/dummy/config/alchemy/config.yml
spec/dummy/db/*.sqlite3*
spec/dummy/postcss.config.js
Expand Down
3 changes: 2 additions & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ group :development, :test do
gem "simplecov-cobertura", "~> 2.1"
# Necessary because GH Actions gem cache does not have this "Bundled with Ruby" gem installed
gem "rexml", "~> 3.2.4"
gem "sassc", "~> 2.4.0" # https://github.com/sass/sassc-ruby/issues/146

# https://github.com/hotwired/turbo-rails/issues/512
if rails_version == "7.1"
Expand Down Expand Up @@ -61,3 +60,5 @@ end
gem "web-console", "~> 4.2", group: :development

gem "rails_live_reload", "~> 0.3.5"

gem "dartsass-rails", "~> 0.5.0"
1 change: 1 addition & 0 deletions Rakefile
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ namespace :alchemy do
bin/rake db:environment:set && \
bin/rake db:migrate:reset && \
bin/rails g alchemy:install --skip --skip-demo-files --auto-accept --skip-db-create && \
bin/rails dartsass:build && \
cd -
BASH
) || fail
Expand Down
1 change: 0 additions & 1 deletion alchemy_cms.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@ Gem::Specification.new do |gem|
gem.add_runtime_dependency "kaminari", ["~> 1.1"]
gem.add_runtime_dependency "originator", ["~> 3.1"]
gem.add_runtime_dependency "ransack", [">= 1.8", "< 5.0"]
gem.add_runtime_dependency "sassc-rails", ["~> 2.1"]
gem.add_runtime_dependency "simple_form", [">= 4.0", "< 6"]
gem.add_runtime_dependency "sprockets", [">= 3.0", "< 5"]
gem.add_runtime_dependency "turbo-rails", [">= 1.4", "< 2.1"]
Expand Down
1 change: 1 addition & 0 deletions app/assets/builds/alchemy/admin.css

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions app/assets/builds/alchemy/admin.css.map

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions app/assets/builds/alchemy/admin/print.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions app/assets/builds/alchemy/admin/print.css.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions app/assets/builds/alchemy/menubar.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions app/assets/builds/alchemy/menubar.css.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions app/assets/builds/alchemy/welcome.css

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions app/assets/builds/alchemy/welcome.css.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions app/assets/builds/tinymce/skins/ui/alchemy/skin.css

Large diffs are not rendered by default.

Loading