Update Tinymce to v5 #2670
Merged
Update Tinymce to v5 #2670
+6,372
−2,469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sascha-karnatz
approved these changes
Jan 2, 2024
Tinymce 5 uses the complete editor interface for min height. We can remove the complex min height calculation now. Raising the default min height to a more usable height.
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
We need the matchMedia mock, because - once again - jsdom has not implemented it (*sigh). Otherwise the spec will not even load, because Tinymce 5 needs this standard HTML API do be defined. The intersection observer spec does not work anymore. The feature itself works in the browser, but not in Jest specs. Skipping for now.
We do not use jQueryUI anymore.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Updates bundled Tinymce Editor to v5.10.9
Notable changes
Updates the theme and icon set to match latest UI changes.
Please follow https://www.tiny.cloud/docs/migration-from-4x/ if you have custom plugins installed.
Screenshots
Checklist