Use Shoelace tooltip for all tooltips and hint bubbles #2629
+617
−812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
changed the title
tvdeyen
force-pushed
the
shoelace-tooltip
branch
from
f8f3e58 to
a99076a
Compare
tvdeyen
changed the title
tvdeyen
force-pushed
the
shoelace-tooltip
branch
4 times, most recently
from
6223028 to
ecc29cc
Compare
Using shoelaces tooltip web component gives us: - Better placement - More accessibility - Lesser code to maintain Introduces a toolbar_button class that is responsible for the margin in toolbars.
tvdeyen
force-pushed
the
shoelace-tooltip
branch
from
0572342 to
d0f7b73
Compare
We now use Shoelace tooltip for button tooltips, let's use them for hint popups as well.
This makes it easier to target links having a toolttip, like before we were able to target a link by a label
We can only set an element dirty if it is present
The partial has been renamed recently
They have been removed while working on an alternative UI that has not been merged yet.
Links displayed as buttons need to be block elements. Using flex to make content centered.
After changing the picture thumbnail name height we need to position the tags accordingly.
tvdeyen
force-pushed
the
shoelace-tooltip
branch
from
d0f7b73 to
4561b7d
Compare
sascha-karnatz
approved these changes
Dec 12, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Using Shoelace tooltip web component gives us:
Introduces a toolbar_button class that is responsible for the margin in toolbars.
Checklist