Include jquery-ui #2601
Merged
Include jquery-ui #2601
+4,144
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is used only to fade in the dialog body during replacement. We can sinmply remove it, because it does not have much of an impact.
and remove the jquery-ui-rails gem, because it does not have the latest jquery-ui with security fixes.
tvdeyen
force-pushed
the
remove-jquery-ui-rails
branch
from
e33164f to
9ae02ef
Compare
sascha-karnatz
approved these changes
Oct 24, 2023
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
tvdeyen
added a commit
that referenced
this pull request
Oct 24, 2023
[7.0-stable] Merge pull request #2601 from tvdeyen/remove-jquery-ui-rails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Include jquery-ui widgets we use and remove the jquery-ui-rails gem, because it does not
have the latest jquery-ui with security fixes.
Since we are working on removing the dependency this is just an intermediate step.
This resolves a security issue.
Checklist