Remove memory leak in ingredients migrator #2493
Merged
+20
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
6.1-reduce-ingredients_migrator-memory
branch
from
75bccb5 to
bb78f69
Compare
|
Specs fixed in #2495 |
By using each instead of map an by eager loading each element individually we reduce the memory usage and prevent it from leaking.
tvdeyen
force-pushed
the
6.1-reduce-ingredients_migrator-memory
branch
from
bb78f69 to
360613c
Compare
sascha-karnatz
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
By using
find_eachinstead ofmapand by eager loading each element individually we reduce the memory usage and prevent it from leaking.Checklist