Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layoutpages configuration #2459

Merged
merged 1 commit into from
Jun 9, 2023
Merged

Fix layoutpages configuration #2459

merged 1 commit into from
Jun 9, 2023

Conversation

oRIOnTx
Copy link
Contributor

@oRIOnTx oRIOnTx commented Apr 15, 2023

What is this pull request for?

Problem: alchemy/admin/pages/update.js.erb - try render partial _page.html.erb, but Alchemy.Sitemap not inialized. Sitemap can't be inialized, because Alchemy::Page can't be root_page and layoutpage in same time

This small solution solve problem, when admin try to update any Shared section configuration and got error

Screenshots

Error example:
image

Remove if no visual changes have been made.

@tvdeyen
Copy link
Member

tvdeyen commented Apr 26, 2023

@oRIOnTx could you please explain what issue this solves? What have you tried to do? Please provide a reproducible example, thanks.

Fix rendering layoutpages items when update configuration
@tvdeyen tvdeyen changed the title Fix shared section configuration Fix layoutpages configuration Jun 5, 2023
@tvdeyen tvdeyen merged commit 19183b2 into AlchemyCMS:main Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants