-
-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate non_stupid_digest_assets gem #2430
Conversation
2bea7f8
to
6b6693b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Could you please make this 2 commits:
- Move the file into the lib folder
- Apply the fix for Ruby 3.2
This way the git history shows exactly what the fix for Ruby 3.2 was.
Thanks for the review, good idea, I will do that. |
Use `File.exist?` instead of `File.exists?`
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
This does not work. Need to figure out why.... |
Hi Thomas, what exactly does not work? I have applied the patch in production in two websites and the tinymce editor is showing correctly and the assets are precompiled fine. |
The whitelist is using Regexp and since the code does not use Regexp to compare the files it needs to create assets without digests for it skips all the tinymce files. Fix is here https://github.com/AlchemyCMS/alchemy_cms/pull/2436/files#diff-c77ddfb34e3a1dae0510164a25a6251cf8532bd8a8cff567bda403b8010cc04e |
Open a page that uses Tinymce. It will not load because it cannot find our alchemy_link plugin |
What is this pull request for?
It integrates the patch from the non_stupid_digest_assets gem, since it is not compatible with Ruby 3.2 anymore.
Closes #2426
Checklist