Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Headline size and level selects as input addons #2398

Merged
merged 1 commit into from
Dec 15, 2022

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Dec 14, 2022

What is this pull request for?

Instead of having a second row in the editor we stick with our theme
of a single input per ingredient by adding the selects as an input
addons. A commonly known UI element.

Screenshots

headline-size-select

headline-level-select

headline-with-sizes-and-level

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen requested a review from mamhoff December 14, 2022 14:28
@tvdeyen tvdeyen marked this pull request as ready for review December 14, 2022 14:28
@tvdeyen tvdeyen force-pushed the update-headline-ingredient-editor branch 2 times, most recently from 3ec9c30 to b95bed0 Compare December 15, 2022 08:58
Instead of having a second row in the editor we stick
with our theme of a single input per ingredient by
adding the selects as an input addons.

A commonly known UI element.
@tvdeyen tvdeyen force-pushed the update-headline-ingredient-editor branch from b95bed0 to 0799e88 Compare December 15, 2022 09:11
@tvdeyen tvdeyen merged commit a272e0c into AlchemyCMS:main Dec 15, 2022
@tvdeyen tvdeyen deleted the update-headline-ingredient-editor branch December 15, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants