Update published_at only after page has been published. #2331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascalbetz
changed the title
|
Thanks, there are some git conflicts and it would be great to have the two commits to be squashed into one. And if you are rebasing anyway, could you please move the issue reference into the commit message body? Thanks again |
tvdeyen
reviewed
May 5, 2022
|
Thanks for the feedback. I'll look into it. |
tvdeyen
reviewed
May 6, 2022
|
|
||
| def ransackable_scopes(_auth_object) | ||
| [:published, :from_current_site, :searchables, :layoutpages] | ||
| end |
There was a problem hiding this comment.
This commit does not belong here. Can you please rebase the branch and remove it?
Closes #2330 Updating published_at only after a public PageVersion has been created or updated to avoid e-tags being created with old PageVersion. re-add Page#publish! since it was public interface
|
okay, done. |
|
Now worries. You can always make this a draft PR telling us that you are still working on it
|
|
Hey Thomas rebased the PR. |
tvdeyen
added a commit
that referenced
this pull request
May 30, 2022
Update published_at only after page has been published.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating published_at only after a public PageVersion has been created or updated.
What is this pull request for?
Issue #2339
Notable changes (remove if none)
Page#published_at is updated async.
Attribute is used in cache key and should only be updated once the page has been published. Since publication is now done in background, the timestamp needs to be updated in the background as well.
Checklist