Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check presence of page_public checkbox #2269

Merged
merged 1 commit into from
Mar 18, 2022
Merged

Check presence of page_public checkbox #2269

merged 1 commit into from
Mar 18, 2022
+15 −14

Conversation

afdev82
Copy link
Contributor

@afdev82 afdev82 commented Mar 18, 2022

What is this pull request for?

Avoid error in the js console if the page_public field is not found in the current dialog.
Discussed already on Slack here

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

Sorry, something went wrong.

@tvdeyen tvdeyen merged commit 938f7cf into AlchemyCMS:main Mar 18, 2022
@afdev82 afdev82 deleted the fix_dialog_error branch March 18, 2022 12:40
@tvdeyen
Copy link
Member

tvdeyen commented Mar 18, 2022

Thank you!

@tvdeyen tvdeyen modified the milestone: 6.0 Mar 18, 2022
@tvdeyen tvdeyen self-assigned this Mar 18, 2022
@phantomwhale phantomwhale mentioned this pull request Mar 30, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mamhoff mamhoff

Assignees

@tvdeyen tvdeyen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@afdev82 @tvdeyen @mamhoff