Fix init link dialog if used in tinymce #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If used inside a tinymce editor we do not have these attributes. We only have them from linked essence or ingredient. Closes AlchemyCMS#2198
robinboening
approved these changes
Oct 12, 2021
|
Thanks for the fix @tvdeyen ! Any idea how to best test this tinymce plugin? While a feature spec will probably work I am thinking if there is another way I haven't even thought of. |
Converting it into a module and then write a jest spec. We even have old jasmine based specs, but they never worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If used inside a tinymce editor we do not have these
attributes. We only have them from linked essence or
ingredient.
Closes #2198