Do not validate element during toggle fold and create #2186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elements with ingredient validations might get invalid on update. Since we do not care about the validations during toggling a UI state we skip them.
If an element has ingredient validations careating it first and calling valid? after that triggers the on update validation callback. Resulting in returning the new template instead. Solved by only building the element and saving it later. This does not trigger the on update callback. To spare an extra save we set the elements position instead of moving it down. The only unnecessary ave we could not prevent is if we paste from clipboard. But this is acceptable.
tvdeyen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Elements with ingredient validations might get invalid on update. Since we do not care about the validations during toggling a UI state we skip them.
If an element has ingredient validations creating it first and calling
valid?after that triggers the on update validation callback. Resulting in returning the new template instead.Solved by only building the element and saving it later. This does not trigger the on update callback.
To spare an extra save we set the elements position instead of moving it down.
The only unnecessary ave we could not prevent is if we paste from clipboard.
But this is acceptable.
Checklist