Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release task #2173

Merged
merged 4 commits into from
Aug 13, 2021
Merged

Release task #2173

merged 4 commits into from
Aug 13, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Aug 12, 2021

What is this pull request for?

Change version string to semver format

According to semver pre releases (like the current beta3) should be
separated with a dash from the version digits.

Add a alchemy:release Rake task

This helps to publish new gem and package versions in one
command. This command also checks if the versions are in sync.
It aborts otherwise.

Checklist

According to semver pre releases (like the current beta3) should be
separated with a dash from the version digits.

We already had this format in the npm package. In order to make a sync
between both the Rubygem and the NPM package we should fix that.
This helps to publish new gem and package versions in one
command. This command also checks if the versions are in sync.
It aborts otherwise.
@tvdeyen tvdeyen requested a review from a team August 12, 2021 14:05
Copy link
Contributor

@robinboening robinboening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Since package.json is already using that format it seems everything is covered 👍

@tvdeyen tvdeyen merged commit 80a85a8 into AlchemyCMS:main Aug 13, 2021
@tvdeyen tvdeyen deleted the release-task branch August 13, 2021 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants