Simplify ingredient creation #2171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tvdeyen
force-pushed
the
simplify-ingredient-creation
branch
from
7d781bc to
3f2b572
Compare
tvdeyen
force-pushed
the
simplify-ingredient-creation
branch
from
3f2b572 to
1120e48
Compare
This causes a lot of issues during creating an ingredient record, because Rails holds a lot of precautions for abstract class. Since this is not necessary for STI to work and we already have validations of all necessary attributes this can safely be removed allowing us to simplify the process of creating an ingredient record.
tvdeyen
force-pushed
the
simplify-ingredient-creation
branch
from
1120e48 to
f5ff098
Compare
Now that we removed abstract_class from the ingredient class we can use all the Rails defaults to create an ingredient instances.
In the element editor with have a feature that creates ingredients that are defined but not created yet. Before we removed the abstract class from Ingredient we needed to create the ingredient on the class instead of the collection. Since the collection is eager loaded it has to be updated with the newly created ingredient in order to prevent the ingredient to be created twice (leading to unique index violation errors).
tvdeyen
force-pushed
the
simplify-ingredient-creation
branch
from
f5ff098 to
aa2ccd0
Compare
tvdeyen
added a commit
to tvdeyen/alchemy_cms
that referenced
this pull request
Aug 27, 2021
This was necessary before we started to use Rails' data store feature in AlchemyCMS#2171 This currently leads to weird bugs around active record dirty falsy thinking the attribute set is not dirty, leading to the data store not being saved.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this pull request for?
Removes the
abstract_classfromAlchemy::IngredientThis caused a lot of issues during creating an ingredient record, because Rails holds a lot of precautions for abstract classes.
Since this is not necessary for STI to work and we already have validations of all necessary attributes this can safely be removed allowing us to simplify the process of creating an ingredient record.
Checklist