Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to update element without tags #2150

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jul 5, 2021

What is this pull request for?

Elements not having tags do not send any element params.
The strong params code needs to fallback to an empty Hash.

Checklist

  • I have followed Pull Request guidelines
  • I have added a detailed description into each commit message
  • I have added tests to cover this change

@tvdeyen tvdeyen added this to the 6.0 milestone Jul 5, 2021
Elements not havin tags do not send any element params.
The strong params code needs to fallback to an empty Hash.
@tvdeyen tvdeyen force-pushed the fix-updating-element branch from 99e582b to 2acadb2 Compare July 5, 2021 07:44
@tvdeyen tvdeyen merged commit b826bae into AlchemyCMS:main Jul 5, 2021
@tvdeyen tvdeyen deleted the fix-updating-element branch July 5, 2021 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant